fix(docs): update ion-segment sample codes#16882
Merged
Merged
Conversation
Adapt docs to 4.0.0-beta.16 breaking change
Member
|
Thank you for the PR! The code in the README is actually generated from the following files: https://github.com/ionic-team/ionic/tree/master/core/src/components/segment/usage Could you update the code in these files and then run |
Contributor
Author
|
Thanks for your feedback! |
Member
|
Thank you! 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt docs to 4.0.0-beta.16 breaking change
Short description of what this resolves:
In the changelog, version beta.16 cited a breaking change for
ion-segmentusage, that was not reflected in the docs.Changes proposed in this pull request:
Ionic Version: beta.16 and later.
Fixes: #