Skip to content

[WIP] Bundle size improvements for angular#16966

Merged
manucorporat merged 4 commits into
masterfrom
angular-bundle-size
Jan 7, 2019
Merged

[WIP] Bundle size improvements for angular#16966
manucorporat merged 4 commits into
masterfrom
angular-bundle-size

Conversation

@manucorporat

@manucorporat manucorporat commented Jan 5, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Move ionicons to a copy task (just to reduce 100% of their overhead) (saves around 40KB)
  • Rollup ionic/angular to fesm5.js
  • Updated stencil to generate the proper entry points to modern es2017 stuff
  • Removed all @input() and now i am using inputs array
  • Removed stuff that should not be exported

screenshot 2019-01-05 at 15 29 26

@ionitron-bot ionitron-bot Bot added package: angular @ionic/angular package package: core @ionic/core package labels Jan 5, 2019
@paulstelzer paulstelzer mentioned this pull request Jan 7, 2019
Closed
@manucorporat manucorporat merged commit 44fb45e into master Jan 7, 2019
@manucorporat manucorporat deleted the angular-bundle-size branch January 7, 2019 21:05
@paulstelzer paulstelzer mentioned this pull request Jan 10, 2019
Closed
pickfire
pickfire reviewed Jan 14, 2019
View reviewed changes
Comment thread angular/src/directives/proxies-list.txt

export const DIRECTIVES = [
d.IonApp,
d.IonApp,

@pickfire pickfire Jan 14, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change related?

@dependabot-preview dependabot-preview Bot mentioned this pull request Jun 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pickfire pickfire pickfire left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

package: angular @ionic/angular package package: core @ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@manucorporat @pickfire