T23362 docker: add kselftest build dependencies to gcc-8 and clang-10#499
Merged
gctucker merged 2 commits intoSep 21, 2020
Merged
Conversation
0d6a446 to
214d7fc
Compare
Collaborator
Author
|
Diff of tests being built without and with this PR, with gcc-8 on arm64 defconfig+kselftest: Also worth noting, the list of remaining directories being skipped with this PR (I guess non-arm64 directories are expected since this is an arm64 build, and bpf requires clang): So the list of extra directories that we might also be able to build with gcc are: |
Collaborator
Author
|
Full build log with this PR applied: |
khilman
approved these changes
Sep 17, 2020
Merged
alexandrasp
approved these changes
Sep 18, 2020
alexandrasp
left a comment
There was a problem hiding this comment.
Small changes, but big impact. :)
Add build dependencies for x86, arm and arm64 to the gcc-8 Docker images. This causes some duplication, but there is no easy way around it at the moment. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
Add build dependencies for kselftest on x86, arm and adm64 to the clang-10 image. The clang-9 one is due to be removed as clang 10.0.1 is the minimal requirement for linux-next now, so leave it unchanged to avoid conflicts. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
214d7fc to
fe85549
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add build dependencies for x86, arm and arm64 to the gcc-8 and
clang-10 Docker images. This causes some duplication, but there is no
easy way around it at the moment.