Skip to content

security: upgrade golang to 1.25.6 to fix CVE-2025-61729#4358

Merged
efiacor merged 11 commits into
kptdev:mainfrom
menahyouyeah:upgrade-go-version
Jan 22, 2026
Merged

security: upgrade golang to 1.25.6 to fix CVE-2025-61729#4358
efiacor merged 11 commits into
kptdev:mainfrom
menahyouyeah:upgrade-go-version

Conversation

@menahyouyeah
Copy link
Copy Markdown
Contributor

Description

This PR upgrades the Go toolchain and base images to version 1.25.6.

Why is this needed?

This update addresses CVE-2025-61729, a high-severity vulnerability in crypto/x509 that allows for potential Denial of Service (DoS) via resource exhaustion when processing malicious certificates.

Changes

  • Updated go.mod to go 1.25
  • Ran go mod tidy to refresh dependencies

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 21, 2026

Deploy Preview for kptdocs ready!

Name Link
🔨 Latest commit feaca8e
🔍 Latest deploy log https://app.netlify.com/projects/kptdocs/deploys/69723942432adf0008dd6f56
😎 Deploy Preview https://deploy-preview-4358--kptdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Signed-off-by: Minna Howell <minnah@google.com>
Signed-off-by: Minna Howell <minnah@google.com>
@menahyouyeah menahyouyeah changed the title security: upgrade golang to 1.25.6 to fix CVE-2025-61729 security: upgrade golang to 1.25.5 to fix CVE-2025-61729 Jan 21, 2026
Signed-off-by: Minna Howell <minnah@google.com>
Copy link
Copy Markdown
Contributor

@efiacor efiacor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to bump the version in the .github workflows also.
ie.

with:
go-version: '>=1.24'

Signed-off-by: Minna Howell <minnah@google.com>
Signed-off-by: Minna Howell <minnah@google.com>
Signed-off-by: Minna Howell <minnah@google.com>
Signed-off-by: Minna Howell <minnah@google.com>
Signed-off-by: Minna Howell <minnah@google.com>
Signed-off-by: Minna Howell <minnah@google.com>
@menahyouyeah
Copy link
Copy Markdown
Contributor Author

It might be good to bump the version in the .github workflows also. ie.

with: go-version: '>=1.24'

Updated the workflows. Since I bumped the go.mod to 1.25.6, the default GitHub runners (which often lag by a patch version or two, currently at 1.25.5) were failing because they couldn't satisfy the strict version check under GOTOOLCHAIN=local. So I updated to 1.25.6 specifically in a few places.

@menahyouyeah menahyouyeah changed the title security: upgrade golang to 1.25.5 to fix CVE-2025-61729 security: upgrade golang to 1.25.6 to fix CVE-2025-61729 Jan 21, 2026
Copy link
Copy Markdown
Contributor

@efiacor efiacor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we go with the following for all workflows?

name: Set up Go
uses: actions/setup-go@v6
with:
go-version-file: go/src/github.com/kptdev/kpt/go.mod
cache: true

the check-latest is redundant if cache=true

Signed-off-by: Minna Howell <minnah@google.com>
Signed-off-by: Minna Howell <minnah@google.com>
@liamfallon
Copy link
Copy Markdown
Contributor

@menahyouyeah
Copy link
Copy Markdown
Contributor Author

Can we go with the following for all workflows?

name: Set up Go uses: actions/setup-go@v6 with: go-version-file: go/src/github.com/kptdev/kpt/go.mod cache: true

the check-latest is redundant if cache=true

yep done thanks for the feedback

@efiacor efiacor merged commit 4eca0a8 into kptdev:main Jan 22, 2026
15 checks passed
@menahyouyeah menahyouyeah deleted the upgrade-go-version branch February 11, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants