Remove the remaining fragments of Porch from kpt#4409
Conversation
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Documentation Updates 1 document(s) were updated by changes in this PR: faqView Changes@@ -50,7 +50,7 @@
- Enables workflows that combine programmatic changes ([functions]) with manual
edits.
- Aims to support mutating and validating admission control on derived packages.
-- Also supports packages, [package orchestration], resource actuation, and GitOps.
+- Also supports packages, resource actuation, and GitOps.
### Do kpt and kustomize work together?
@@ -122,8 +122,6 @@
[Configuration as Data]:
https://github.com/kptdev/kpt/blob/main/docs/design-docs/06-config-as-data.md
-[package orchestration]:
- https://github.com/kptdev/kpt/blob/main/docs/design-docs/07-package-orchestration.md
[the kubernetes resource model]:
https://github.com/kubernetes/design-proposals-archive/blob/main/architecture/resource-management.md
[declarative application management in kubernetes]: |
There was a problem hiding this comment.
Pull request overview
This PR removes the remaining Porch-related fragments from the kpt repository, completing the migration of Porch to the Nephio project. The removal includes documentation, test files, and other references that were retained until the Porch documentation was updated in its new home.
Changes:
- Removed Porch documentation files including user guides, UI installation guides, and design documents
- Deleted Porch-related test files and configuration
- Updated references in the book index and roadmap to reflect Porch's new location
- Removed unused test utilities and helper functions for Porch testing
Reviewed changes
Copilot reviewed 54 out of 67 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| porch/README.md | Removed redirect notice file |
| pkg/test/porch/*.go | Removed test utilities for Porch integration |
| e2e/testdata/porch/*.yaml | Removed end-to-end test configurations for Porch commands |
| documentation/content/en/guides/to-be-removed/*.md | Removed Porch user guides and UI installation documentation |
| documentation/content/en/book/08-package-orchestration/_index.md | Removed Porch chapter from the book |
| docs/design-docs/07-package-orchestration.md | Removed Porch design documentation |
| docs/design-docs/08-package-variant.md | Removed PackageVariant controller design document |
| internal/util/update/merge3/testdata//.yaml | Updated test data to replace porch.kpt.dev API references with infer.kpt.dev |
| internal/util/render/executor_test.go | Adjusted whitespace alignment in test structure |
| go.mod | Moved gopkg.in/yaml.v3 dependency from direct to indirect |
| documentation/content/en/book/_index.md | Updated chapter numbering after removing Chapter 8 |
| docs/ROADMAP.md | Updated package orchestration section to reference Porch's new location |
| Makefile | Added duplicate go generate command line |
| CONTRIBUTING.md | Removed Package Orchestrator section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 54 out of 67 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f193ba2 to
0798a6e
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 53 out of 66 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
0798a6e to
35675e1
Compare
The Porch documentation has recently been updated on the Porch project. We retained the Porch documentation on kpt until the documentation in Porch was updated but now the documentation and some other small remaining Porch fragments (such as tests that were missed in earlier PRs) can be removed from the kpt repo.