Changing favicons to the new logo#4496
Merged
Merged
Conversation
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
CsatariGergely
requested review from
efiacor,
kispaljr,
liamfallon and
mozesl-nokia
as code owners
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dosubot
Bot
added
size:S
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the documentation site’s favicon assets to match a new logo, adding/refreshing multiple favicon formats under documentation/static/favicons/.
Changes:
- Replaced/added PNG favicon assets (including web app manifest icon sizes).
- Added/updated
site.webmanifestfor PWA icon metadata. - Updated
favicon.svgandfavicon.icoto the new logo.
Reviewed changes
Copilot reviewed 1 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| documentation/static/favicons/web-app-manifest-512x512.png | Updated 512×512 manifest icon asset. |
| documentation/static/favicons/web-app-manifest-192x192.png | Updated 192×192 manifest icon asset. |
| documentation/static/favicons/site.webmanifest | Added manifest metadata referencing the icons. |
| documentation/static/favicons/favicon.svg | Updated SVG favicon asset (currently embeds a PNG). |
| documentation/static/favicons/favicon.ico | Updated ICO favicon bundle. |
| documentation/static/favicons/favicon-96x96.png | Updated 96×96 PNG favicon asset. |
| documentation/static/favicons/apple-touch-icon.png | Updated Apple touch icon asset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> Assisted-by: Copilot Code Review:not-known Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the documentation site’s favicon assets to use the new logo by adding a web app manifest and an SVG favicon.
Changes:
- Added
site.webmanifestdefining PWA icon entries and theme/background colors - Added a new
favicon.svgasset generated by RealFaviconGenerator
Reviewed changes
Copilot reviewed 1 out of 11 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| documentation/static/favicons/site.webmanifest | Adds manifest configuration for favicon/PWA icons |
| documentation/static/favicons/favicon.svg | Adds the new favicon asset (SVG wrapper around embedded PNG) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Some Copilot comments to check. |
mozesl-nokia
approved these changes
Apr 29, 2026
liamfallon
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.