feat(encoder): add multi-format support with mp3, aac, and opus presets#41
Merged
Conversation
- Introduce formatPreset type mapping each format to its codec, bitrate, sample rate, muxer, and extension - Support --format flag (mp3, aac, opus) with mp3 as default - MP3: CBR 112/192kbps, 44.1kHz, LAME quality 3, 20.5kHz lowpass, ID3v2.4 tags with cover art - AAC: CBR 64/128kbps, 44.1kHz, iTunes MP4 atoms with cover art, .m4a extension - Opus: VBR ~32/~48kbps, 48kHz, Vorbis comments (text only), .opus extension - Update filename generation to use format-specific extensions instead of hardcoded .mp3 - Remove obsolete ID3v2 writer library; use FFmpeg muxer-native tagging for all formats - Add encoder tests covering each format's preset configuration - Update documentation and CLI reference for multi-format output - Add .tailor.yml configuration for linting and static analysis - Refactor command-line interface to show Ready to encode message with format name Closes #9 Signed-off-by: Martin Wimpress <code@wimpress.io>
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Requires human review: This PR introduces multi-format support with new encoding presets, replaces the ID3 tag writer with FFmpeg muxer-native tagging, and modifies the core encoder pipeline, which are significant changes to critical business logic that require human review to ensure correctness and avoid regressions.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9