feat: support trailing line comment for mage:import#480
Merged
Conversation
Contributor
Author
|
@natefinch or anyone wondering if you'll get a chance to review this PR? I noticed many PRs haven't had any comments for some months so perhaps this project is unmaintained now - it happens, but hoping to be able to confirm it. Thanks. |
Contributor
Author
|
Thanks a lot @natefinch! Just wondering if there's anything left to do to merge. Cheers |
Member
|
Nope! I guess I forgot to hit the button:) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
//mage:importis only read from leading doc comments for an import statement, not trailing line comments. This makes it incompatible with tools like gosimports. It seems reasonable to support line comments too and is luckily not difficult