getFunction() ignoring receiver on imports#509
Merged
Conversation
Contributor
perrito666
approved these changes
Nov 24, 2024
Contributor
perrito666
left a comment
perrito666
left a comment
There was a problem hiding this comment.
ill submit a test for this
perrito666
added a commit
to perrito666/mage
that referenced
this pull request
Nov 24, 2024
It fails against master before merging the patch on magefile#509 (review)
natefinch
pushed a commit
that referenced
this pull request
Nov 24, 2024
* This adds a test to bug 508 It fails against master before merging the patch on #509 (review)
Contributor
Author
|
Thanks, it was on my to-do list but hadn't had time yet :) |
Contributor
|
My pleasure @na4ma4 , I had some time on my hands and I felt it was the least I could do after taking months to review your fix :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getFunction()ignores the receiver, selecting the first matching function name regardless of scope.Fixes #508