support for inline doc comments on optional flags#549
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for showing inline (trailing) parameter comments as documentation for optional flag arguments in mage -h <target> output, including a new Flags: section when appropriate.
Changes:
- Extend parsed function argument metadata to carry an optional inline comment and render it in help output.
- Update parsing to preserve and/or recover inline parameter comments from Go source.
- Update docs and add tests covering multi-flag and single-flag documented help output.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
site/content/targets/_index.en.md |
Updates documentation to demonstrate inline flag doc comments and new help output format. |
parse/testdata/optargs.go |
Adds a test fixture function with inline comments on optional parameters. |
parse/parse_test.go |
Extends optional-args parsing tests to assert captured inline comments. |
parse/parse.go |
Adds Arg.Comment, computes whether to show a Flags: section, formats flag docs, and attempts to extract inline param comments. |
mage/testdata/optargs/magefile.go |
Adds magefile targets used by help-output tests for documented flags. |
mage/template.go |
Updates help template to emit [<flags>] usage and optional Flags: section. |
mage/args_test.go |
Adds assertions for new help output that includes Flags: and inline flag documentation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e.g.