Renaming, Logging, View changes#2
Merged
marionbarker merged 3 commits intoJun 4, 2023
Merged
Conversation
marionbarker
added a commit
that referenced
this pull request
Jun 12, 2023
Removed unnecessary xcscheme files, Moved up algorithmExperimentsSection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Algorithm Experiments section in settings was refactored. The header for this section now includes a warning emoji and the settings inside have been changed. The "Enable Enhanced AutoBolus" option was replaced by "Glucose Based Partial Application", which reflects its state (On/Off) next to the option name.
The file GlucoseBasedApplicationFactor.swift was renamed to GlucoseBasedApplicationFactorStrategy.swift to better reflect its role in the system. The content of this file was also refactored. The struct inside was renamed to match the new filename and variable references were updated accordingly.
Changes were also made to LoopDataManager.swift. In this file, the method for creating a dosing strategy based on user settings was updated to use GlucoseBasedApplicationFactorStrategy instead of the old GlucoseBasedApplicationFactor. Additionally, the logging process was updated from print to logger.debug and the user default key used to fetch the state of the Glucose Based Partial Application feature was changed to match the new naming scheme.
The file EnhancedAutoBolusSelectionView.swift was removed and replaced with a new file, GlucoseBasedApplicationFactorSelectionView.swift. This new file provides a SwiftUI view for controlling the Glucose Based Partial Application feature.
Lastly, the SettingsView.swift file was updated. The internal state for storing the state of the Glucose Based Partial Application feature was changed to reflect the new naming scheme.