Suggest specifying font-size and margin-block on h1#37827
Merged
chrisdavidmills merged 5 commits intomdn:mainfrom Jan 29, 2025
Merged
Suggest specifying font-size and margin-block on h1#37827chrisdavidmills merged 5 commits intomdn:mainfrom
chrisdavidmills merged 5 commits intomdn:mainfrom
Conversation
github-actions
Bot
added
Content:HTML
Contributor
|
Preview URLs External URLs (2)URL:
(comment last updated: 2025-01-29 09:56:16) |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
estelle
reviewed
Jan 27, 2025
Member
estelle
left a comment
estelle
left a comment
There was a problem hiding this comment.
language and link suggestions
chrisdavidmills
requested changes
Jan 28, 2025
Contributor
chrisdavidmills
left a comment
chrisdavidmills
left a comment
There was a problem hiding this comment.
@zcorpan couple more quick comments for you. Thanks for making this update!
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Simon Pieters <zcorpan@gmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
chrisdavidmills
approved these changes
Jan 29, 2025
Contributor
chrisdavidmills
left a comment
chrisdavidmills
left a comment
There was a problem hiding this comment.
LGTM2; thanks @zcorpan!
zcorpan
added a commit
to zcorpan/content
that referenced
this pull request
Jan 30, 2025
This regressed in mdn#37827.
Closed
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See whatwg/html#7867
Description
Add a new section to help developers avoid the special
h1insectiondefault styling.Motivation
We're trying to remove the special default styling in the spec and in Firefox. Devtools will have a warning, but the warning should have a link to help developers know what to do and why. My plan is to link to this new section.
Additional details
https://bugzilla.mozilla.org/show_bug.cgi?id=1937568
Related issues and pull requests