Skip to content

Wrap main script in function patch#15

Merged
mgechev merged 5 commits into
mgechev:masterfrom
david-gang:wrap-main-script-in-function-patch
Feb 26, 2015
Merged

Wrap main script in function patch#15
mgechev merged 5 commits into
mgechev:masterfrom
david-gang:wrap-main-script-in-function-patch

Conversation

@david-gang
Copy link
Copy Markdown
Contributor

It would be important to have the unminified version wrapped because i can concatenate many files to vendor.js and create a sourcemap

… if we concatenate multiple javascripts, we can create a source map and debug teh code more easy
… if we concatenate multiple javascripts, we can create a source map and debug teh code more easy
… if we concatenate multiple javascripts, we can create a source map and debug teh code more easy
@mgechev
Copy link
Copy Markdown
Owner

mgechev commented Feb 26, 2015

Thanks! This pull request reverts the changes you did in bower.json. Do you want to fix this before merging?

@david-gang
Copy link
Copy Markdown
Contributor Author

This should fix the issue

@mgechev
Copy link
Copy Markdown
Owner

mgechev commented Feb 26, 2015

Yes, thanks for the PR!

mgechev added a commit that referenced this pull request Feb 26, 2015
@mgechev mgechev merged commit 2aba807 into mgechev:master Feb 26, 2015
@david-gang david-gang deleted the wrap-main-script-in-function-patch branch March 1, 2015 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants