Make exported DllGetActivationFactory zero-alloc (take 2)#1401
Merged
Conversation
Sergio0694
added
performance
Sergio0694
force-pushed
the
user/sergiopedri/marshal-string-span
branch
from
f73316f to
ea406bd
Compare
Sergio0694
force-pushed
the
user/sergiopedri/naot-winrt-exports
branch
2 times, most recently
from
fa62a4c to
f02bf33
Compare
Sergio0694
changed the base branch from
user/sergiopedri/naot-winrt-exports
to
staging/AOT
Sergio0694
force-pushed
the
user/sergiopedri/marshal-string-span
branch
from
ea406bd to
9a1ab96
Compare
Sergio0694
force-pushed
the
user/sergiopedri/marshal-string-span
branch
from
fe3f4b2 to
768dbf3
Compare
manodasanW
reviewed
Jan 25, 2024
manodasanW
approved these changes
Jan 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second attempt from #1399 😄
This PR makes the exported
DllGetActivationFactoryzero-alloc, skipping the uselessstring runtimeClassIdparameter.It does so by leveraging the new
MarshalString.FromAbiUnsafeAPI added in #1400, and it updates the generatedModuletype so that when not on .NET Standard, theGetActivationFactorymethod will actually take aReadOnlySpan<char>parameter (with a secondstringoverload just forwarding to it). The new native exports for NativeAOT can then just call this newReadOnlySpan<char>overload using the newFromAbiUnsafemarshalling method.