Rewrite event registration token logic to improve performance, trimming#1448
Merged
Conversation
Sergio0694
requested review from
MichalStrehovsky,
jkoritzinsky,
jkotas and
manodasanW
Sergio0694
commented
Jan 16, 2024
jkotas
reviewed
Jan 16, 2024
Joe4evr
reviewed
Jan 16, 2024
Member
Author
|
@jkotas thank you for all the help and for your time to review the PR, I appreciate it! 🙂 |
manodasanW
reviewed
Jan 17, 2024
manodasanW
reviewed
Jan 17, 2024
manodasanW
approved these changes
Jan 17, 2024
Base automatically changed from
user/sergiopedri/tweak-event-tokens
to
staging/AOT
January 17, 2024 11:36
Sergio0694
force-pushed
the
user/sergiopedri/optimize-event-table
branch
from
86196b8 to
b09e7e4
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rewrites the logic to compute event registration tokens, see: dotnet/runtime#96947.
This is both faster, and allows NativeAOT to trim signficantly more stuff, as it makes all delegate targets non-reflectable.