Fix 'CsWinRTIncludes' check in .targets file#1625
Merged
Sergio0694 merged 3 commits intoJun 6, 2024
Merged
Conversation
Contributor
|
There's also |
Member
Author
|
That property wasn't being checked before this PR either, so I just kept that behavior as is. |
manodasanW
approved these changes
Jun 4, 2024
Sergio0694
force-pushed
the
user/sergiopedri/fix-global-vtable-target
branch
from
967c78a to
72d96e1
Compare
Sergio0694
force-pushed
the
user/sergiopedri/fix-global-vtable-target
branch
from
72d96e1 to
c224578
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow up to #1604. This PR fixes the .targets file to make sure that
CsWinRTCcwLookupTableGeneratorEnabledis correctly set tofalsein cases whereCsWinRTIncludeis set to somestringvalue, including multilines. This also fixes Win2D.