Fix couple build issues related to authoring scenarios#1643
Merged
Conversation
…ng associated with winmds due to being a dependency of an authoring project and fixing issue where multiples references of the same file are not handled such that the latest is chosen.
Sergio0694
approved these changes
Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a couple issues related to authoring scenarios:
winmdof the authoring project which isn't true. Instead, it should be the authoring project dll is the one that implements the winmd and the others are just copied over. This addresses that by no longer looping over all the managed dlls but they are still added for publishing.WinRT.Runtimewhere a version can come from the nuget reference and the other from the Windows SDK projection, they were not correctly resolved to choose the higher version. We are now usingResolveAssemblyReferencesto resolve those issues so that way we do not need to handle them ourselves.CopyLocalalso while copying them.Tested with a couple different project reference scenarios to ensure things work as expected.