Add explicit GUID support for delegates and non-synthesized interfaces.#1792
Merged
manodasanW merged 7 commits intoSep 18, 2024
Merged
Conversation
Sergio0694
reviewed
Sep 17, 2024
Sergio0694
reviewed
Sep 17, 2024
Member
Sergio0694
left a comment
Sergio0694
left a comment
There was a problem hiding this comment.
Can you please also add a couple tests for various cases in the authoring test project?
MartyIX
reviewed
Sep 17, 2024
Contributor
Author
|
I've added a test in, though I haven't personally tested it myself as I couldn't get CsWinRT to build. |
Member
|
CI is not running because this is a fork. I cherry-picked to a branch here to kick it off, it's here. |
Member
|
Fixed a typo, new CI run here. |
Sergio0694
approved these changes
Sep 17, 2024
Member
Sergio0694
left a comment
Sergio0694
left a comment
There was a problem hiding this comment.
CI is green (just failing on publish, unrelated), changes look good to me.
Thank you! 🙂
manodasanW
reviewed
Sep 18, 2024
manodasanW
approved these changes
Sep 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not too sure about synthesized interfaces, as it looks like multiple might be generated?
Closes #1790