Skip to content

Fix exception when using funcs and take another approach to escape assembly name#1836

Merged
manodasanW merged 2 commits into
masterfrom
manodasanw/fixfunc
Oct 18, 2024
Merged

Fix exception when using funcs and take another approach to escape assembly name#1836
manodasanW merged 2 commits into
masterfrom
manodasanw/fixfunc

Conversation

@manodasanW
Copy link
Copy Markdown
Member

  • We were previously checking the nested expression to get the parameters. This typically worked before unless it is a func and there was a nested invocation. Fixed to not use the nested ones to get parameters.
  • We previously tried to escape any invalid characters from the assembly name. Given that seems to actually be trickier, change the approach to escape anything not on our valid list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants