Fix exception when using funcs and take another approach to escape assembly name#1836
Merged
Conversation
Member
manodasanW
commented
Oct 17, 2024
- We were previously checking the nested expression to get the parameters. This typically worked before unless it is a func and there was a nested invocation. Fixed to not use the nested ones to get parameters.
- We previously tried to escape any invalid characters from the assembly name. Given that seems to actually be trickier, change the approach to escape anything not on our valid list.
Sergio0694
approved these changes
Oct 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.