Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

feat: add getMeetingInfo to TeamsInfo #3738

Merged
mdrichardson merged 4 commits into from
Jun 14, 2021
Merged

feat: add getMeetingInfo to TeamsInfo #3738

mdrichardson merged 4 commits into from
Jun 14, 2021

Conversation

@mdrichardson
Copy link
Contributor

@mdrichardson mdrichardson commented Jun 10, 2021 •
edited
Loading

Fixes #3723

Description

Adds a getMeetingInfo method to TeamsInfo.

Notes

Bots implementing this must add this to their manifest.json:

"webApplicationInfo": {
        "id": "<MicrosoftAppId>",
        "resource": "<urlToApp>",
        "applicationPermissions": [
            "OnlineMeeting.ReadBasic.Chat"
        ]
    }

Testing

image

mdrichardson
mdrichardson commented Jun 10, 2021
View reviewed changes
mdrichardson
mdrichardson commented Jun 10, 2021
View reviewed changes
@mdrichardson mdrichardson mentioned this pull request Jun 10, 2021
Closed
12 tasks
@coveralls
Copy link

coveralls commented Jun 10, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 936500211

  • 18 of 18 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 85.408%
Totals Coverage Status
Change from base Build 923037352: 0.02%
Covered Lines: 19260
Relevant Lines: 21451
💛 - Coveralls

@mdrichardson mdrichardson changed the title feat: add getMeetingDetails to TeamsInfo feat: add getMeetingInfo to TeamsInfo Jun 10, 2021
@mdrichardson mdrichardson marked this pull request as ready for review June 10, 2021 23:30
@mdrichardson mdrichardson requested a review from a team as a code owner June 10, 2021 23:30
joshgummersall
joshgummersall reviewed Jun 14, 2021
View reviewed changes
Copy link
Contributor

@joshgummersall joshgummersall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple quick questions, otherwise this looks good.

@mdrichardson mdrichardson merged commit ec197fe into microsoft:main Jun 14, 2021
@mdrichardson mdrichardson deleted the getMeetingDetails branch June 14, 2021 16:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@joshgummersall joshgummersall joshgummersall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Teams - get meeting details (JS)

3 participants

@mdrichardson @coveralls @joshgummersall