Misc Cleanup & Refactor#1576
Merged
Merged
Conversation
vazois
commented
Feb 24, 2026
vazois
commented
Contributor
- Refactor resp.bench and add support for InProc benchmarking
- Add missing license statement from files.
- Add support for internal client setname and setinfo.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs miscellaneous cleanup and refactoring across the Garnet codebase with three main objectives:
Changes:
- Adds support for InProc benchmarking in Resp.benchmark by integrating embedded server capabilities
- Adds missing MIT license headers to 43 files across test, sample, module, library, and benchmark code
- Implements CLIENT SETNAME and SETINFO support in GarnetClient and GarnetClientSession for better client identification
Reviewed changes
Copilot reviewed 75 out of 84 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/Garnet.test/* (9 files) | Added MIT license headers to test utilities and JSON path tests |
| samples/ETag/* (4 files) | Added MIT license headers to ETag sample code |
| playground/ClusterStress/* (7 files) | Removed entire ClusterStress project from solution |
| playground/Bitmap/BitOp.cs | Fixed label indentation for consistency |
| modules/GarnetJSON/JSONPath/* (14 files) | Added MIT license headers to JSON path implementation files |
| modules/GarnetJSON/GarnetJSON.csproj | Removed unused Azure.Storage.Blobs package reference |
| libs/storage/Tsavorite/* (5 files) | Standardized license headers removing "All rights reserved" phrase |
| libs/server/TLS/GarnetTlsOptions.cs | Removed trailing whitespace |
| libs/server/Properties/AssemblyInfo.cs | Added InternalsVisibleTo attribute for Resp.benchmark |
| libs/server/Objects/SortedSetGeo/GeoSearchOptions.cs | Added MIT license header |
| libs/server/Lua/* (2 files) | Fixed license header formatting and indentation |
| libs/server/Custom/ObjectInputExtensions.cs | Added MIT license header |
| libs/resources/ResourceUtils.cs | Added MIT license header |
| libs/cluster/Server/Gossip/GarnetServerNode.cs | Added clientName parameter for gossip client identification |
| libs/cluster/Server/ClusterConfig.cs | Added LocalNodeEndpoint property |
| libs/client/GarnetClient.cs | Implemented CLIENT SETNAME/SETINFO support with new clientName parameter |
| libs/client/ClientSession/GarnetClientSession.cs | Implemented CLIENT SETNAME/SETINFO support with new clientName parameter |
| benchmark/Resp.benchmark/* (multiple files) | Major refactoring: added InProc client type, reorganized files into Common/OfflineBench/OnlineBench folders, added server options, removed unused imports |
| benchmark/Device.benchmark/Device.benchmark.csproj | Removed duplicate BenchmarkLoggerProvider.cs link |
| benchmark/BDN.benchmark/* (2 files) | Added MIT license header and GetRespSessions method for multi-session support |
| Garnet.slnx | Removed ClusterStress project reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vazois
force-pushed
the
vazois/dev-cleanup
branch
from
a533bdc to
3d15ab6
Compare
badrishc
approved these changes
Feb 25, 2026
* Parallel ACL tests sometimes run forever, cleaned up to properly use async and also check server responses. * nit * format * timeouts * reduce timeout * address comments * nit * nit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
