[dev] Wait for Vector Set replay in tests#1723
Merged
kevin-montrose merged 6 commits intoApr 22, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates cluster test utilities so that “replica AOF sync” waits not only for matching AOF offsets, but also for async Vector Set replication replay to quiesce—addressing timing gaps where vector operations may still be pending after offsets match.
Changes:
- After
WaitForReplicaAofSyncobserves equal replication offsets, it now waits for Vector Set replay quiescence on the replica. - Introduces
WaitForVectorSetReplayQuiescenceto callVectorManager.WaitForVectorOperationsToComplete()on the replica. - Uses
UnsafeAccessorto accessGarnetServer.storeWrapperfrom tests in order to reachDefaultDatabase.VectorManager.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ions aren't considered done before they are applied; remove test helper that waited explicitly on VectorSetManager
…ome, but that's already kinda weird and allows higher throughput for vector set ops
badrishc
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dev targeting equivalent of #1722