Fix TLS blocking issue when buffer is doubled [dev]#1743
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a TLS read-path edge case in NetworkHandler where doubling the transport receive buffer during an async TLS read could fail to trigger the follow-up read needed to drain remaining decrypted bytes, potentially leaving data stuck until more network bytes arrive.
Changes:
- Add an
initialRetryflag to TLS async read helpers to carry “buffer just doubled; attempt another read” state across async continuations. - Propagate the retry state when chaining from the
Task<int>-based completion handler into the general async TLS reader loop. - Update call sites after authentication and in the rare async branch of
Read()to pass the new parameter.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vazois
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.