Honor configured AOF segment size in TsavoriteLogSettings

[Copilot]

Fix: AOF truncation ignores configured segment size (always uses default 1 GB granularity).

GarnetServerOptions.GetAofSettings() was constructing TsavoriteLogSettings without setting SegmentSizeBits, so the AOF always used Tsavorite's default 1 GB segment, preventing file-level truncation at smaller AofSizeLimit values.

• Add a new AofSegmentSize option (default 1g, preserving existing behavior).
• Plumb AofSegmentSize into TsavoriteLogSettings.SegmentSizeBits in GetAofSettings(), with page-size <= segment-size validation.
• Update defaults.conf and website configuration docs.
• Add AofSegmentSizeFlowsToTsavoriteLogSettings test covering default, override, and validation.
• Address review feedback: validate AOF page/memory/segment size relationships before allocating GetAofDevice so a validation failure cannot leak file handles. (Also fixes the same pre-existing pattern for the page-vs-memory check.)
• Address review feedback: in the test, dispose LogCommitManager (also IDisposable) in addition to LogDevice, and use try/finally so disposal runs even if an assertion fails.
• Validate: targeted config tests + all 28 RespAofTests pass.

[Copilot]

Pull request overview

This PR makes AOF file segmentation honor server configuration by introducing an explicit AofSegmentSize option and plumbing it into the TsavoriteLogSettings used for AOF. This aligns AOF truncation/rollover behavior with configured limits by allowing smaller on-disk segment (file) granularity than Tsavorite’s prior implicit default.

Changes:

• Add new AofSegmentSize server option (default 1g), including defaults and documentation.
• Pass SegmentSizeBits into AOF TsavoriteLogSettings and add page-size vs segment-size validation.
• Add config test coverage to ensure the option flows through and validation triggers.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
website/docs/getting-started/configuration.md	Document new --aof-segment-size configuration setting.
test/Garnet.test/GarnetServerConfigTests.cs	Add tests verifying default/override segment size and invalid page>segment validation.
libs/server/Servers/GarnetServerOptions.cs	Add AofSegmentSize option, compute bits, plumb into TsavoriteLogSettings, and validate page vs segment.
libs/host/defaults.conf	Define default AofSegmentSize: 1g.
libs/host/Configuration/Options.cs	Add CLI option --aof-segment-size with memory-size validation and map into GarnetServerOptions.

Comments suppressed due to low confidence (1)

test/Garnet.test/GarnetServerConfigTests.cs:1363

• Same as above: this second GetAofSettings call disposes only LogDevice; LogCommitManager should also be disposed, and cleanup should be in a finally/using pattern to avoid leaking resources if assertions throw.

            serverOptions = options.GetServerOptions();
            serverOptions.GetAofSettings(0, out logSettings);
            ClassicAssert.AreEqual(1, logSettings.Length);
            ClassicAssert.AreEqual(1L << 26, logSettings[0].SegmentSize);
            foreach (var s in logSettings)
                s.LogDevice?.Dispose();

[rdavisunr]

@badrishc I’m not seeing this change in release/v1 (v1.1.x).

Could this be cherry-picked/backported into the next v1.1.x release?

[badrishc]

@copilot - please backport this PR to target release/v1 (and update version in that PR so its merge will create a new release).