Skip to content

Fix Slot Validation for Custom Proc#712

Merged
vazois merged 20 commits into
microsoft:mainfrom
vazois:vazois/custom-proc-cluster
Oct 17, 2024
Merged

Fix Slot Validation for Custom Proc#712
vazois merged 20 commits into
microsoft:mainfrom
vazois:vazois/custom-proc-cluster

Conversation

@vazois

@vazois vazois commented Oct 9, 2024

Copy link
Copy Markdown
Contributor

This PR fixes slot verification for custom proc.
It introduces the following:

  • Iterative slot verification interface.
  • Slot verification fix for WATCH command.
  • Separation of WATCH_MS and WATCH_OS as separate commands instead of WATCH subcommands
  • Added BDN for custom proc

RespClusterBench

Method Mean Error StdDev Allocated
Get 22.13 us 0.028 us 0.026 us -
Set 21.47 us 0.041 us 0.039 us -
MGet 18.13 us 0.024 us 0.022 us -
MSet 15.55 us 0.032 us 0.030 us -
CPBSET 178.25 us 0.398 us 0.372 us -

RespClusterDisableSlotVerificationBench

Method Mean Error StdDev Allocated
Get 18.58 us 0.027 us 0.025 us -
Set 17.19 us 0.026 us 0.023 us -
MGet 17.77 us 0.042 us 0.039 us -
MSet 15.67 us 0.034 us 0.032 us -
CPBSET 152.47 us 0.159 us 0.149 us -

@vazois vazois force-pushed the vazois/custom-proc-cluster branch 4 times, most recently from e52db1e to 6740fc8 Compare October 11, 2024 22:19
Comment thread libs/server/Transaction/TransactionManager.cs
@vazois vazois force-pushed the vazois/custom-proc-cluster branch from fce109d to d51994c Compare October 14, 2024 15:40
@vazois vazois marked this pull request as ready for review October 15, 2024 18:03
@vazois vazois force-pushed the vazois/custom-proc-cluster branch from 1f564b8 to e9884d5 Compare October 15, 2024 18:06
@vazois vazois force-pushed the vazois/custom-proc-cluster branch 2 times, most recently from 7bb1063 to 48da0b9 Compare October 17, 2024 19:06
@vazois vazois force-pushed the vazois/custom-proc-cluster branch from 48da0b9 to 805d573 Compare October 17, 2024 19:07
@vazois vazois merged commit 73c6571 into microsoft:main Oct 17, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 17, 2024
@vazois vazois deleted the vazois/custom-proc-cluster branch June 26, 2025 16:56
@vazois vazois restored the vazois/custom-proc-cluster branch June 26, 2025 16:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants