Skip unnecessary py.typed file exist checks. #7652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
erictraut
reviewed
Apr 9, 2024
erictraut
reviewed
Apr 9, 2024
This comment has been minimized.
This comment has been minimized.
erictraut
approved these changes
Apr 9, 2024
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
importResolver, it already checks if apy.typedfile exists before callinggetPyTypedInfo, using the file system cache, so there's no need to recheck it insidegetPyTypedInfo. This minor improvement results in a 500~1000ms speed boost for certain cases where thepy.typedfile is checked across many folders, such as inindexer.It would be beneficial to extend the cache to the file system itself so all code could benefit from it, but for now, the improvement is specific to the
importResolver, where the cache exists.vs