Add magnet icon#24
Merged
miguelsolorio merged 2 commits intomicrosoft:masterfrom Sep 11, 2020
piersdeseilligny:master
Merged
Conversation
|
|
miguelsolorio
approved these changes
Sep 11, 2020
miguelsolorio
left a comment
miguelsolorio
left a comment
There was a problem hiding this comment.
👏 Thanks so much for this PR! You did this perfectly matching the grid + angles. I'll add the build files and then will merge this in shortly 🍻
Feel free to file an issue for your Windows build issues and will see if I can fix those.
|
This is now in version |
Contributor
Author
|
Amazing, thank you ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My extension (betterfountain) needed a magnet icon, so I thought I would submit it as a pull request, as it is a fairly generic icon which could be useful to other extension authors too:
I've made sure it respects the style of the other icons and is correctly aligned to the grid, so there shouldn't be any issues. However it isn't included in the
distfolder, as I wasn't able to actually build this (as there's still a few issues when trying to build on a Windows machine)