fix: handle scoped packages with _index on package root #285
Merged
aeschli merged 3 commits intomicrosoft:mainfrom Aug 31, 2022
wkillerud:fix/scoped-root
Merged
fix: handle scoped packages with _index on package root #285aeschli merged 3 commits intomicrosoft:mainfrom wkillerud:fix/scoped-root
aeschli merged 3 commits intomicrosoft:mainfrom
wkillerud:fix/scoped-root
Conversation
Collaborator
|
Thanks @wkillerud. I added another commit to fix the open. The reason was a unnecessary encoding of the I updated the test in the following way
Please speak up, if I misunderstand how |
dbaeumer
approved these changes
Aug 30, 2022
Contributor
Author
|
Nice, thank you!
If
Yes |
Collaborator
Yes, that's how it's implemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #284
Like I mentioned in the issue, there's still a bug when I cmd/ctrl + click the link
@use "@foo/bar";where VS Code tries to open the file of that name. I wasn't able to figure out where and how to fix that.