Add option to remove tab close buttons

[jez9999]

There should be a preference for removing tab close buttons (it just needs to apply the css style ".close-editor-action {display:none;}" to the interface) - tab close buttons make it too easy to accidentally close a tab, and you can use middle-click instead anyway.

[jez9999]

@bpasero @hashhar As this has now been implemented by you when will it get checked into the main codebase?

[bpasero]

@jez9999 @hashhar I am not seeing a PR yet?

[hashhar]

@bpasero @jez9999 I am only able to hide and show the close buttons but they don't refresh automatically. You would have to at least drag the tab to make the setting take effect.

I am unable to get it to repaint the window at my will.
I'll look into it again but right now I have campus placement sessions coming up so I'm a little too busy.

[jez9999]

@hashhar Your patch modifies the code where the tabs are created, but is there a way to apply a global stylesheet to the UI? If so, you could just add or remove a CSS styling that hides all the tab close buttons. That seems the most straightforward way to do it.

[bpasero]

@hashhar also keep in mind that you do not want to hide the dirty decorator which is drawn on top of the close action.

[hashhar]

Thanks for the input. I'll take it up again after the placements are over.

[jez9999]

@hashhar How long will the placements take? This seems like a very small patch and I'd really like to get rid of those tab close buttons as soon as possible. :-)

[hashhar]

You are welcome to try and write a patch if you would like. I think it should be over by 28th of this month.