OSX system services shortcuts not recognized

[unnamedcrewman]

I'm really enjoying working with VSCode, and appreciate the work going on here. One issue I'm having (OSX El Capitan) is that VSCode doesn't seem to recognize some of the system wide services keyboard shortcuts I've set up to work with text from any application.

I have some System Services that run scripts, which I activate via a mouse menu, and those work fine. I have others that I activate via the keyboard. For example, I have a System Service to take selected text and use a shell script to append it to a special file. I have a mouse menu item that invokes that service via the the keyboard shortcut I've defined: Cmd-Shift-Alt-Ctrl-A. This works just fine, but I cannot invoke the same service using the actual keys on the keyboard.

All the shortcuts I'm using have Cmd-Shift-Alt-Ctrl as the modifiers, so I don't think there are any conflicts with existing keyboard shortcuts. Other system wide keyboard shortcuts do work, so I'm not sure what the issue is with these particular, OSX System Services related ones. Is it a problem with the modifiers, or is there some issue currently with OSX system services support?

[bpasero]

@unnamedcrewman out of curiosity, does it work if you bind a simpler shortcut that is not yet taken by VS Code?

@alexandrudima fyi

[unnamedcrewman]

Thanks for the quick response.

I rebound the shortcut to ctrl+cmd+H which is not listed, as far as I can tell, among the default keyboard shortcuts. My "append selected text to file" script/Service works fine with these keys in Sublime Text, as well as text highlighted in the browser and so on. However this key-binding still fails to work from VSCode. I tried several other key binding combos that seemed unique, and all worked except in VSCode.

If it matters, the mouse shortcut I use is simply a PopClip for Mac plugin that runs the system service by name, rather than by invoking the keyboard shortcut. The PopClip plugin works perfectly, which seems to suggest that the issue is not with the service itself interacting with VSCode, but rather something with the key-binding mechanism instead.

[alexdima]

This is most likely caused by us keeping the input textarea empty. I can only imagine that this external tool works by finding the current focused UI element and extracting the selected text from it. So it is more likely that the shortcuts do work, its just that the external tool finds no selected text and there is no visible output in the file.

[alexdima]

To investigate if a1bd50f fixes this too