Editor-area terminals are not restored after quit on 1.74.0

[adamfeldman]

Type: Bug

1. Ensure terminal.integrated.enablePersistentSessions is enabled. Ensure window.restoreWindows is set to all, preserve or one (any option that will restore the last open window after quiting and re-opening VSCode).
2. Start a terminal in the editor area, e.g. using the command "Terminal: Create New Terminal in Editor Area". Type something into the terminal e.g. cd ~.
3. Reload VSCode via "Developer: Reload Window". Note that the terminal tab in the editor area is still there (restored) after the window is reloaded. This is the expected behavior.
4. Quit VSCode then reopen the application. Note that the terminal tab is not present (is not restored) when the window is restored (and since there is no terminal tab, there is also nowhere to restore the session to 🙂) .
   • This is unexpected behavior as previously this terminal tab would be restored into the editor area, with its session history, even after quitting and reopening VSCode.

Another terminal persistence bug on 1.74.0, also related to killing terminals: #168601

VS Code version: Code 1.74.0 (5235c6b, 2022-12-05T16:37:54.581Z)
OS version: Darwin arm64 22.2.0
Modes:
Sandboxed: No

System Info

Item	Value
CPUs	Apple M1 Max (10 x 24)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_renderer: enabled_on video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: disabled_off
Load (avg)	2, 4, 7
Memory (System)	32.00GB (2.82GB free)
Process Argv	--crash-reporter-id be1f0084-53c0-4bd2-b437-891afea08dd8
Screen Reader	no
VM	0%

Extensions (16)

Extension	Author (truncated)	Version
vscode-neovim	asv	0.0.94
calva	bet	2.0.321
file-browser	bod	0.2.11
portal	djb	0.35.0
viml	dun	0.1.7
prettier-vscode	esb	9.10.3
vscode-htmlhint	HTM	1.0.4
vscode-sshfs	Kel	1.25.0
ssh-config-syntax-highlighter	mou	0.0.4
sqltools	mtx	0.26.0
sqltools-driver-pg	mtx	0.4.0
errorlens	use	3.6.0
learn-vim	vin	0.0.28
vspacecode	VSp	0.10.10
whichkey	VSp	0.11.3
markdown-all-in-one	yzh	3.5.0

[meganrogge]

I cannot reproduce that in Insider's

editor.mov

[meganrogge]

@adamfeldman have you typed in the terminal before reloading? if not, that's by design

[adamfeldman]

Pardon me @meganrogge, I was unclear in the original writeup. The problem occurs in step 4 and is now reflected in edits above. Thank you!

Regarding the direct question: yes, I have typed in the terminal before reloading.

[meganrogge]

/duplicate #133512

[adamfeldman]

Reviving editor-area terminals was working great in 1.73.x. This was marked as a duplicate of a feature request. Is it not a regression? @meganrogge