Skip to content

standaloneTheme.defines Always return false. #169220

@Aaaaash

Description

@Aaaaash

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: Monaco Editor
  • OS Version:

Steps to Reproduce:

The standaloneTheme.defines method always return false.

https://github.com/microsoft/vscode/blob/main/src/vs/editor/standalone/browser/standaloneThemeService.ts#L115-L117

public defines(colorId: ColorIdentifier): boolean {
    return Object.prototype.hasOwnProperty.call(this.getColors(), colorId);
}

https://github.com/microsoft/vscode/blob/main/src/vs/editor/standalone/browser/standaloneThemeService.ts#L75

private getColors(): Map<string, Color> {
    // ...
}

Because this.getColors() return type is a Map, so we should use this.getColors().has(colorId) in here.

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable buginsiders-releasedPatch has been released in VS Code Insidersmonaco-editorthemesColor theme issuesverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions