Does this issue occur when all extensions are disabled?: Yes/No
- VS Code Version: Monaco Editor
- OS Version:
Steps to Reproduce:
The standaloneTheme.defines method always return false.
https://github.com/microsoft/vscode/blob/main/src/vs/editor/standalone/browser/standaloneThemeService.ts#L115-L117
public defines(colorId: ColorIdentifier): boolean {
return Object.prototype.hasOwnProperty.call(this.getColors(), colorId);
}
https://github.com/microsoft/vscode/blob/main/src/vs/editor/standalone/browser/standaloneThemeService.ts#L75
private getColors(): Map<string, Color> {
// ...
}
Because this.getColors() return type is a Map, so we should use this.getColors().has(colorId) in here.
Does this issue occur when all extensions are disabled?: Yes/No
Steps to Reproduce:
The
standaloneTheme.definesmethod always return false.https://github.com/microsoft/vscode/blob/main/src/vs/editor/standalone/browser/standaloneThemeService.ts#L115-L117
https://github.com/microsoft/vscode/blob/main/src/vs/editor/standalone/browser/standaloneThemeService.ts#L75
Because
this.getColors()return type is aMap, so we should usethis.getColors().has(colorId)in here.