Leaving duplicate workspace nodes When refreshing

[yiliang114]

Reproduction step:

1. Open https://vscode.dev/, then open any project from github, such as https://vscode.dev/github/yiliang114/vscode
2. After the file tree is loaded, refresh the page directly without any other operations.
3. You can see that the data of the file tree has disappeared, leaving only a temporary folder named workspace name, but in fact, there is already a workspace name on tree item.

Version: 1.74.3
Commit: 97dec17
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36
Embedder: vscode.dev

[lramos15]

@jrieken I think this is FS provider related. Let me know if you disagree, it also might be a lifecycle thing cc @bpasero

[jrieken]

I don't think so, I remember that the explorer always had issues with that. Since it's the explorer showing the error I suggest that the investigation starts there. It's likely that it gives us to restore a persisted state before the actual extension registers the FS

[bpasero]

cc @sandy081, I remember some tricks with how extension activation works with custom schemes, but I forgot.

[sandy081]

In configuration land I wait until the FSP is registered like this

vscode/src/vs/workbench/services/configuration/browser/configuration.ts

Line 667 in 1ed7421

await whenProviderRegistered(workspaceIdentifier.configPath, this.fileService);

[joyceerhl]

This scenario happens when the workbench has already loaded and the page is being refreshed.

1. The page reload triggers stopExtensionHosts in abstractExtensionHost.ts
2. In this case the FS provider is coming from an extension, so stopping the extension host also disposes the means the FS provider gets disposed
3. The explorer service listens for onDidChangeFileSystemProviderRegistrations and resets the tree input

   vscode/src/vs/workbench/contrib/files/browser/explorerService.ts

   Line 122 in 8cd2eb1

   await this.view.setTreeInput();

4. This leads to the explorer tree view getting rerendered
5. The explorer has a decorations provider which runs after the rerender and it calls stat on the resource. At this point there is no filesystem capable of handling the stat anymore, so you get the ! Unable to resolve workspace folder decoration, just before the page reloads

This seems like mostly a visual problem rather than missing/broken functionality, maybe the explorer view can avoid setting the tree input and triggering the layout if the workbench is about to go down anyway?

[yiliang114]

This scenario happens when the workbench has already loaded and the page is being refreshed.

1. The page reload triggers stopExtensionHosts in abstractExtensionHost.ts
2. In this case the FS provider is coming from an extension, so stopping the extension host also disposes the means the FS provider gets disposed
3. The explorer service listens for onDidChangeFileSystemProviderRegistrations and resets the tree input

   vscode/src/vs/workbench/contrib/files/browser/explorerService.ts

   Line 122 in 8cd2eb1

   await this.view.setTreeInput();

4. This leads to the explorer tree view getting rerendered
5. The explorer has a decorations provider which runs after the rerender and it calls stat on the resource. At this point there is no filesystem capable of handling the stat anymore, so you get the ! Unable to resolve workspace folder decoration, just before the page reloads

This seems like mostly a visual problem rather than missing/broken functionality, maybe the explorer view can avoid setting the tree input and triggering the layout if the workbench is about to go down anyway?

Before refreshing the page, is the setTreeInput called in onDidChangeFileSystemProviderRegistrations callback to reduce memory leaks? If not, I think the data of the file tree is not reset, will look better to experience it when the onDidChangeFileSystemProviderRegistrations triggered by refresh. It is a bit strange that the data disappears faster than refresh behavior.

[yiliang114]

onDidChangeFileSystemProviderRegistrations Triggered by events here

vscode/src/vs/platform/files/common/fileService.ts

Line 73 in 25514d8

this._onDidChangeFileSystemProviderRegistrations.fire({ added: false, scheme, provider });