More types for CompletionItemKind enum

[rkeithhill]

And then add an appropriate icon to display in completion lists. The PowerShellEditorServices extension helps the user auto-complete paths. When you have a list of folder contents it is very helpful to have an icon to distinguish between files and folders.

Compare this UI from VSCode for path completion:

To the UI from PowerShell ISE:

Having a nice, flat icon for a folder would be very nice to show in this list.

[daviwil]

Agreed, this would be great to have!

[jrieken]

@bgashler1 fyi

[jrieken]

related #4201

[jrieken]

• Folder/Directory
• Event (Add Event into CompletionItemKind enum #5407)

[Jerry-Hong]

@jrieken Can I use it now?

[jrieken]

@Jerry-Hong If by it you mean the currently existing ComplemtionItemKind member "yes". Otherwise you have to wait until this issue is resolved ;-)

[DustinCampbell]

Looking forward to this.

[DustinCampbell]

And FWIW, it'd be great to get several more of the icons from VS. We use many of these for C# in VS completion and finding analogs in VS Code is always a bit of a compromise.

Here are icons for which there is no good representation in VS Code's CompletionItemKind:

• Event
• Struct
• Delegate
• Extension method
• Constant
• Enum member
• Operator
• Type parameter
• Versions of all icons with accessibility overlays (e.g. private, protected, internal, etc.)

Here's the basic list of what we use in completion: https://github.com/dotnet/roslyn/blob/master/src/Features/Core/Portable/Completion/CompletionTags.cs

This is the level of detail we use for Visual Studio: https://github.com/dotnet/roslyn/blob/master/src/Features/Core/Portable/Shared/Extensions/ISymbolExtensions_2.cs#L14-L169

It'd be great if I could replicate the icons in VS Code.

[jrieken]

Yeah, our plan is to allow for custom icons