Touch doesn't work in Suggest widget

[filip-hejsek]

• VSCode Version: Code 1.36.1 (2213894, 2019-07-08T22:59:35.033Z)
• OS Version: Windows_NT x64 10.0.17763

Steps to Reproduce:

1. Open some file in VSCode
2. Press Ctrl+Space
3. Touch some completion item. Nothing happens

If you don't have a touch device, you can open dev tools (Ctrl+Shift+I) and click Toggle device toolbar to emulate touch.

The issue is in SuggestWidget - it disables mouseSupport and then only handles mouse events (but mouseSupport also handles touch events)

vscode/src/vs/editor/contrib/suggest/suggestWidget.ts

Lines 503 to 519 in 5ea298a

	this.list = new List(this.listElement, this, [renderer], {
	useShadows: false,
	openController: { shouldOpen: () => false },
	mouseSupport: false
	});
	this.toDispose.add(attachListStyler(this.list, themeService, {
	listInactiveFocusBackground: editorSuggestWidgetSelectedBackground,
	listInactiveFocusOutline: activeContrastBorder
	}));
	this.toDispose.add(themeService.onThemeChange(t => this.onThemeChange(t)));
	this.toDispose.add(editor.onDidLayoutChange(() => this.onEditorLayoutChange()));
	this.toDispose.add(this.list.onMouseDown(e => this.onListMouseDown(e)));
	this.toDispose.add(this.list.onSelectionChange(e => this.onListSelection(e)));
	this.toDispose.add(this.list.onFocusChange(e => this.onListFocus(e)));
	this.toDispose.add(this.editor.onDidChangeCursorSelection(() => this.onCursorSelectionChanged()));
	this.toDispose.add(this.editor.onDidChangeConfiguration(e => e.contribInfo && applyIconStyle()));

This was already once fixed in list widget (#9338), but then broken again in suggest widget.

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Touch control does not work by default on Linux (#73305)
• Touch support can be improved in webviews (#21812)
• Support for scrolling on touch-enabled devices (#53775)
• Add touch mode (#71702)
• Sidebar minimap/scroll doesn't work with surface touch screen (#75672)

[davidreis97]

Hi there, first time contributor here, I'd like to have a go at this one, but I'm having trouble replicating the issue, as you can see in the gif. Maybe this bug doesn't exist anymore?

EDIT: The issue does exist, I just wasn't emulating touch events properly on the dev tools.

[joaomoreno]

@davidreis97 Maybe it's a Windows only issue.

[davidreis97]

@joaomoreno Thanks for the tip, after further testing I found the issue does exist on both MacOS and Windows, I just wasn't emulating touch events properly on the dev tools. Looks like toggling device toolbar on the dev tools, to emulate a mobile viewport, as suggested by @filip-hejsek, is not enough to turn mouse clicks into touch events, I actually had to set "Touch" to "Force enabled" on the Sensors settings of the dev tools.

I'll start looking into how to fix this.