Test save and open dialog title proposed API

[alexr00]

Refs: #82871

• macOS @rebornix
• linux @mjbvz
• windows @connor4312

Complexity: 3

The OpenDialogOptions and SaveDialogOptions both include a title property in the proposed API. Write an extension that shows an open and a save dialog with the title option set.
Verify:

• That the title specified is used when the dialog is shown. Compare the behavior to that of File -> Open Workspace and File -> Save Workspace as.. If the title of those dialogs is set to mention "workspace", then this proposed API should also set the title on the OS that you're using.
• That the API makes sense (the name just comes from electron)
• That the simple file dialog respects this title. This can be tested by enabling the simple file dialog in settings or by connecting to a remote.

[GustavoASC]

Maybe it's a good idea to test on different operating systems.
According to PR #90493:

Note: on this version of Ubuntu the Save Dialog title is not shown, but it's an OS-related behaviour.
Every save dialog of VSCode running on Ubuntu 19.10 ignores the specified title as can be seen on 'File -> Save Workspace As...' (On Windows it shows 'Save Workspace' but on Ubuntu no title is shown).

Thanks in advance!
If you need anything I am on hand to help 😄

[alexr00]

Updated. Good feedback, thank you @GustavoASC !

[rebornix]

@alexr00 what's the expected behavior on macOS which is using the native dialog? I didn't see title bar on the dialogs.

[alexr00]

@rebornix I'm not sure. What happens when you run File -> Open Workspace and File -> Save Workspace as.. If the title of those dialogs is set to mention "workspace", then this proposed API should also set the title on the OS that you're using.

[GustavoASC]

@alexr00 @rebornix

I'm not sure. What happens when you run File -> Open Workspace and File -> Save Workspace as.. If the title of those dialogs is set to mention "workspace", then this proposed API should also set the title on the OS that you're using.

If title is never shown on any dialog while running on macOS, it's a behavior of the operating system. Thus, we could add a description above title parameter on OpenDialogOptions and SaveDialogOptions pointing this out.

[rebornix]

I think that's the system behavior, we'd better document it.

[GustavoASC]

@rebornix I'll make a pull request improving the title documentation on vscode.proposed.d.ts 👍