Run menu does not remember dynamic launch configurations

[connor4312]

Refs: #95837

Version: 1.45.0-insider (user setup)
Commit: 0778354f3a6a2c21b7f738a5e6b02e2f1c765e73
Date: 2020-04-27T05:42:11.567Z
Electron: 7.2.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363

Steps to Reproduce:

1. Select a dynamic launch configuration
2. Reload the window
3. The dynamic launch configuration is no longer the selected item in the Run menu

I assume this is because the dynamic configurations are provided asynchronously/aren't present when the view is first loaded.

Switching out the selected configuration after extension activation would be awkward. Maybe the run view should have a 'stub' item and assume that the previously selected dynamic configuration will be provided once activation completes (and only reset the selected item if it doesn't exist after activation).

[isidorn]

Yes, this is the limitation of the current approach. Since they come async they are not present when view loaded.
Your idea of having a stub item makes sense. Though moving this out to may when we finalise the debug dropdown work with regards to dynamic configurations.

[isidorn]

Will have to reopen this one due to the way I fixed #100265
More details can be found in that issue. In short we are no longer storing whole configurations, thus the best we can do is store origin and name, which would lead us to ask for configuration as soon as vscode starts as when user launches. This is not the optimal experience. Thus I am open for ideas and PRs.