Address feedback in #101467#105880
Merged
alexdima merged 2 commits intomicrosoft:masterfrom Sep 2, 2020
Merged
Conversation
Member
|
Thank you! |
Contributor
Author
|
@alexdima I've remembered why I haven't used I think it's better to match browser behavior and revert code back to |
Member
|
I agree that this is the behaviour of CSS, but these are editor settings, the behaviour of out-of-range values doesn't need to conform to the CSS specification. I think it is OK if we are consistent with our other settings, so we clamp small/large values. IIRC we do the same for fontSize and other editor settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses feedback in #101467 (comment)
Couple of notes:
enumnow only used to provide autocompletion suggestions and renamed accordingly.errorMessagewill be shown only from first item inanyOftype: 'number'should be first otherwise number validationValue is above the maximum of 1000.won't be shown for numbers, however it can be moved lower to have same error message for1001and"10001"/cc @alexdima @jrieken