Added additional colour options for differing git staging statuses#107318
Added additional colour options for differing git staging statuses#107318joaomoreno merged 2 commits intomicrosoft:masterfrom mwood77:99129-theme-colour-git-staged
Conversation
|
|
mwood77
changed the title
joaomoreno
left a comment
joaomoreno
left a comment
There was a problem hiding this comment.
I've addressed my comments with a commit on top and will merge it.
| } | ||
| }, | ||
| { | ||
| "id": "gitDecoration.stageAddedResourceForeground", |
There was a problem hiding this comment.
stageAdded doesn't exist. There's untracked and there's added, both states already have individual colors.
| "colors.stageModified": "Color for resources which have been staged, but modified.", | ||
| "colors.stageDeleted": "Color for resources which have been staged, but deleted.", |
There was a problem hiding this comment.
There's got to be a better description here.
| "light": "#FF661F", | ||
| "dark": "#FFAB85", | ||
| "highContrast": "#ca541d" | ||
| } | ||
| }, | ||
| { | ||
| "id": "gitDecoration.stageDeletedResourceForeground", | ||
| "description": "%colors.stageDeleted%", | ||
| "defaults": { | ||
| "light": "#ad0707", | ||
| "dark": "#c74e39", | ||
| "highContrast": "#c74e39" |
There was a problem hiding this comment.
I don't think we should change the default colors, so let's just use today's colors. This is about enabling themes to overwrite this, not to change the default themes.
|
Thanks! 🍻 |
|
Thanks for the feedback! |
|
@joaomoreno @mwood77 please make sure to document this new color here: https://github.com/microsoft/vscode-docs/blob/73633a2eb1e302903f29523f88265c755417a5b0/api/references/theme-color.md#L684-L684 |
|
raised @ microsoft/vscode-docs#4047 |
|
@bpasero I already did this 3 days ago on |
|
Thanks! |
3 participants
This PR fixes #99129 - added the ability to colourize different git staging statuses.
The staged statuses include:
The default colours have been set to be similar, albeit slightly different tha what the conventional
U, A, M, Dgit indicator colours. This way users can, at a glance, see the different statuses.