Skip to content

Fixes outline: shift + tab needs to be pressed twice for focus to go to title actions#107339

Merged
jrieken merged 1 commit intomicrosoft:masterfrom
jeanp413:fix-107209
Sep 24, 2020
Merged

Fixes outline: shift + tab needs to be pressed twice for focus to go to title actions#107339
jrieken merged 1 commit intomicrosoft:masterfrom
jeanp413:fix-107209

Conversation

@jeanp413
Copy link
Copy Markdown
Contributor

This PR fixes #107209

The changes done in 351fbf4 are no longer needed after the view refactor done at the beginning of the year.
Did some changes in the CSS to be able to focus the tree when the message class is active. Took as reference the timeline view.
Also deleted _inputContainer which wasn't used at all.

@jrieken jrieken assigned jrieken and unassigned eamodio Sep 24, 2020
@jrieken jrieken self-requested a review September 24, 2020 07:11
Copy link
Copy Markdown
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, working well

@jrieken jrieken merged commit c2ee62c into microsoft:master Sep 24, 2020
@bpasero bpasero added this to the September 2020 milestone Sep 24, 2020
@jeanp413 jeanp413 deleted the fix-107209 branch September 24, 2020 07:22
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Outline: shift + tab needs to be pressed twice for focus to go to title actions

4 participants