Implement Pseudoterminal.onDidChangeName #115276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Tyriar
requested changes
Jan 28, 2021
habibkarim
changed the title
habibkarim
changed the title
habibkarim
commented
Feb 1, 2021
habibkarim
commented
Feb 1, 2021
src/vs/workbench/contrib/terminal/browser/terminalProcessExtHostProxy.ts
Outdated
Show resolved
Hide resolved
Tyriar
reviewed
Feb 1, 2021
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Thanks for the changes, I'll bring this up at the API sync tomorrow so we can hopefully move forward with this
Member
|
Sorry about the delay, have to push this again |
Tyriar
requested changes
Apr 1, 2021
src/vs/workbench/contrib/terminal/browser/terminalProcessExtHostProxy.ts
Outdated
Show resolved
Hide resolved
Tyriar
approved these changes
Apr 1, 2021
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Thanks for the PR, should be able to get this into proposed for the April release 🙂
Member
|
Didn't make April unfortunately, I missed the auto merge CI failure. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #114898