Skip to content

Update PHP grammar #120339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
roblourens merged 1 commit into from
Apr 5, 2021
Merged

Update PHP grammar #120339

roblourens merged 1 commit into from
Apr 5, 2021

Conversation

@KapitanOczywisty
Copy link
Contributor

@KapitanOczywisty KapitanOczywisty commented Apr 1, 2021

⚠️ Important note ⚠️ There is one more commit upstream, but please DO NOT merge it yet. I think that PR was merged by mistake, since was very old and not maintained anymore. It's reverting major SQL changes, however atom and vscode are using different syntax for SQL and even if they tested PR properly - which I doubt, still could be some breaking changes in vscode. We need to test this properly for now or push to revert reverted changes.

This PR is fixing 2 small issues with PHP syntax.

Assign: @roblourens

This PR fixes #116847 #120042

@roblourens roblourens added this to the April 2021 milestone Apr 5, 2021
roblourens
roblourens approved these changes Apr 5, 2021
View reviewed changes
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roblourens roblourens merged commit 1c04d9f into microsoft:main Apr 5, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2021
@KapitanOczywisty KapitanOczywisty deleted the patch-1 branch April 3, 2025 16:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@roblourens roblourens roblourens approved these changes

Assignees

@roblourens roblourens

Labels

None yet

Projects

None yet

Milestone

April 2021

Development

Successfully merging this pull request may close these issues.

Incorrect PHP 8 attributes syntax highlight

2 participants

@KapitanOczywisty @roblourens