Skip to content

Fixes horizontal scrollbar is too narrow in split settings editor JSON #121027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
roblourens merged 1 commit into from
Apr 12, 2021
Merged

Fixes horizontal scrollbar is too narrow in split settings editor JSON #121027

roblourens merged 1 commit into from
Apr 12, 2021

Conversation

@jeanp413
Copy link
Contributor

@jeanp413 jeanp413 commented Apr 10, 2021

This PR fixes #121026

Remove padding to keep size of header container same as before => 34px

vscode/src/vs/workbench/contrib/preferences/browser/preferencesEditor.ts

Line 830 in 01466cf

layout: size => this.editablePreferencesEditor && this.editablePreferencesEditor.layout(new DOM.Dimension(size, this.dimension.height - 34 /* height of header container */)),

@jeanp413 jeanp413 mentioned this pull request Apr 10, 2021
Closed
roblourens
roblourens approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roblourens roblourens merged commit e5bef43 into microsoft:main Apr 12, 2021
@roblourens roblourens added this to the April 2021 milestone Apr 12, 2021
@jeanp413 jeanp413 deleted the fix-121026 branch April 12, 2021 18:17
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@roblourens roblourens roblourens approved these changes

Assignees

@roblourens roblourens

Labels

None yet

Projects

None yet

Milestone

April 2021

Development

Successfully merging this pull request may close these issues.

Horizontal scrollbar is too narrow in split settings editor JSON running from sources

2 participants

@jeanp413 @roblourens