Initial implementation of drag and drop api #122239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexr00
requested changes
Apr 27, 2021
Member
alexr00
left a comment
alexr00
left a comment
There was a problem hiding this comment.
Looking really good so far! I haven't gotten to test it out yet since we've just started our endgame here, but I want to try it out later this week.
This is a feature that we will want to highlight in our extension samples, and it looks like you're already testing it out as you develope there ✔ Would you also be able to make a PR so that one of the tree extension samples shows off the new API and feature?
alexr00
reviewed
Apr 29, 2021
alexr00
requested changes
Apr 29, 2021
Member
alexr00
left a comment
alexr00
left a comment
There was a problem hiding this comment.
Just a few last tweaks. I intend to merge this PR on Monday (We branch for release on Friday and are mostly on taking bugfixes until then.)
alexr00
approved these changes
May 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has the initial work for supporting drag and drop behavior in contributed tree
I'll implement the reparent logic and refresh the tree view in next pull request
Screen.Recording.2021-04-26.at.1.41.48.PM.mov
.