Skip to content

Conversation

@gjsjohnmurray
Copy link
Contributor

This PR fixes #123831

/assign @isidorn

@isidorn
Copy link
Collaborator

isidorn commented May 14, 2021

Yes I think we explicitly decided that the clients have to specify that they allow commands to be run.
Since this url is coming from an extension, which can already run any command this is fine.
Thus approved and merging

fyi @jrieken

@gjsjohnmurray thanks a lot for this PR!

@isidorn isidorn added this to the May 2021 milestone May 14, 2021
@isidorn isidorn added the debug Debug viewlet, configurations, breakpoints, adapter issues label May 14, 2021
@isidorn isidorn merged commit 27966a2 into microsoft:main May 14, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2021
@gjsjohnmurray gjsjohnmurray deleted the fix-123831 branch August 16, 2024 04:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

debug Debug viewlet, configurations, breakpoints, adapter issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Command URL in debug extension ErrorResponse Message is ignored

2 participants