Better paired operators for R#155882
Merged
aeschli merged 2 commits intomicrosoft:mainfrom Sep 13, 2022
Merged
Conversation
aeschli
approved these changes
Sep 12, 2022
dbaeumer
approved these changes
Sep 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes three improvements to how paired operators are handled in R
'is very common to use un-paired in R comments, as part of roxygen2 documentation markup, see https://cran.r-project.org/web/packages/roxygen2/vignettes/roxygen2.html`is most commonly used to create non-syntactic variable names (similar to SQL), e.g.`a b c` <- 1creates a variable nameda b c(bound to 1)%is most commonly used for infix operators, see https://cran.r-project.org/doc/manuals/r-devel/R-lang.html#Operators. Lone%has no meaning in R, but still shouldn't always be paired in strings/commentsSome hand-holding about other odds-and-ends needed to complete this small PR would be appreciated, thanks!