Fix search editor title not updating #156011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProKashif
previously approved these changes
Jul 23, 2022
roblourens
reviewed
Aug 4, 2022
Member
roblourens
left a comment
roblourens
left a comment
There was a problem hiding this comment.
Is there also an issue at line 174-177?
Member
|
Thanks for the PR, good catch |
Contributor
Author
Yeah, that looks wrong too. I'm not as clear on what |
roblourens
approved these changes
Aug 4, 2022
Member
roblourens
left a comment
roblourens
left a comment
There was a problem hiding this comment.
Looks great to me, thank you!
rzhao271
approved these changes
Aug 4, 2022
joyceerhl
pushed a commit
that referenced
this pull request
Aug 10, 2022
* Fix search editor title not updating * Share old name with resolveModels * Tweak name Co-authored-by: Rob Lourens <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155855.
This fixes the search editor title not updating until you focus on a different editor in the same editor group. It looks like this was introduced by a fix for #145749.
To test, open a search editor and change the search text. The title should update.