Add env for terminalProcess getCwd Unicode path on macOS #157377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
approved these changes
Aug 8, 2022
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Works great, thanks a lot for investigating this!
lramos15
approved these changes
Aug 8, 2022
joyceerhl
pushed a commit
that referenced
this pull request
Aug 10, 2022
Add env for terminalProcess getCwd Unicode path on macOS
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83496, should also close #145364, and close #150136 since the root cause is the same.
Explanation
lsofwon't support Unicode output unless provided LANG in environment variables, which causing cwd issues above.Reference:
https://opensource.apple.com/source/lsof/lsof-68/lsof/lsof.man.auto.html