Skip to content

Search Tree #161022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andreamah merged 20 commits into from
Sep 23, 2022
Merged

Search Tree #161022

andreamah merged 20 commits into from
Sep 23, 2022

Conversation

@andreamah
Copy link
Contributor

@andreamah andreamah commented Sep 16, 2022 •
edited
Loading

Shows the search results in a toggle-able tree.

image

image

Fixes #20224
Fixes #161141

@andreamah andreamah self-assigned this Sep 16, 2022
@tjx666
Copy link
Contributor

tjx666 commented Sep 19, 2022

any setting to enable this?

@andreamah
Copy link
Contributor Author

andreamah commented Sep 19, 2022

any setting to enable this?

It's not in the editor yet, this PR needs to be merged first 🙂

roblourens
roblourens reviewed Sep 20, 2022
View reviewed changes
@roblourens
Copy link
Member

roblourens commented Sep 20, 2022

Another thing I thought of - the selected state should be persisted when I reload the window. Either per-workspace or globally - we can check what scm does.

@andreamah andreamah marked this pull request as ready for review September 21, 2022 18:06
@vscodenpa vscodenpa added this to the September 2022 milestone Sep 21, 2022
roblourens
roblourens previously approved these changes Sep 21, 2022
View reviewed changes
roblourens
roblourens reviewed Sep 22, 2022
View reviewed changes
@andreamah andreamah enabled auto-merge (squash) September 23, 2022 01:33
@andreamah andreamah merged commit b7683ef into main Sep 23, 2022
@andreamah andreamah deleted the andreamah/issue20224 branch September 23, 2022 01:49
@grumBit grumBit mentioned this pull request Sep 23, 2022
Closed
@ypapouin
Copy link

ypapouin commented Sep 23, 2022

Thanks for implementing this long awaited feature, I just made a test on latest insider in pressing the Collapse All button twice raised an error: TreeError [SearchView] Tree element not found: [object Object]

image

The tree view also miss the in-tree filtering (CTRL+F) like the one for files:
image

This was referenced Sep 23, 2022
Closed
Closed
@andreamah
Copy link
Contributor Author

andreamah commented Sep 23, 2022

Thanks for implementing this long awaited feature, I just made a test on latest insider in pressing the Collapse All button twice raised an error: TreeError [SearchView] Tree element not found: [object Object]

image

The tree view also miss the in-tree filtering (CTRL+F) like the one for files: image

Tracking these issues in #161616 and #161617. Thanks for testing it out 😊

@ypapouin ypapouin mentioned this pull request Oct 6, 2022
Closed
@unrevised6419
Copy link

unrevised6419 commented Oct 6, 2022

THANK YOU 💙

bow

@tranngocson1996
Copy link

tranngocson1996 commented Nov 3, 2022

Respect 👍🏿

@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@roblourens roblourens roblourens approved these changes

Assignees

@andreamah andreamah

Labels

None yet

Projects

None yet

Milestone

September 2022

Development

Successfully merging this pull request may close these issues.

Invalid editor shown when pressing enter on folder root in search results search results in a tree view

7 participants

@andreamah @tjx666 @roblourens @ypapouin @unrevised6419 @tranngocson1996 @vscodenpa