Skip to content

Apply env var collection path prefixes in shell integration scripts when mac+login shell#171066

Merged
Tyriar merged 12 commits intomainfrom
tyriar/99878
Jan 11, 2023
Merged

Apply env var collection path prefixes in shell integration scripts when mac+login shell#171066
Tyriar merged 12 commits intomainfrom
tyriar/99878

Conversation

@Tyriar
Copy link
Copy Markdown
Contributor

@Tyriar Tyriar commented Jan 11, 2023

Fixes #99878

pwsh doesn't need the fix which is why it's excluded.

@Tyriar Tyriar added this to the January 2023 milestone Jan 11, 2023
@Tyriar Tyriar requested a review from meganrogge January 11, 2023 14:19
@Tyriar Tyriar self-assigned this Jan 11, 2023
Comment thread src/vs/platform/terminal/common/environmentVariable.ts Outdated
Comment thread src/vs/platform/terminal/node/terminalEnvironment.ts
Comment thread src/vs/workbench/contrib/terminal/browser/media/shellIntegration-bash.sh Outdated
Comment thread src/vs/workbench/contrib/terminal/browser/media/shellIntegration-bash.sh Outdated
Comment thread src/vs/workbench/contrib/terminal/browser/media/shellIntegration-bash.sh Outdated
Tyriar and others added 4 commits January 11, 2023 06:27
Co-authored-by: Megan Rogge <merogge@microsoft.com>
…on-bash.sh

Co-authored-by: Megan Rogge <merogge@microsoft.com>
…on-bash.sh

Co-authored-by: Megan Rogge <merogge@microsoft.com>
…on-bash.sh

Co-authored-by: Megan Rogge <merogge@microsoft.com>
@Tyriar Tyriar requested a review from meganrogge January 11, 2023 14:29
@Tyriar Tyriar merged commit 90aced5 into main Jan 11, 2023
@Tyriar Tyriar deleted the tyriar/99878 branch January 11, 2023 15:44
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prepending PATH env var with environmentVariableCollection doesn't work on macOS

2 participants